T2: avoid maybe uninitialized warning #8751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afabri
added
Ready to be tested
Pkg::Triangulation_2
Warnings
|
As expected the warning is gone. @MaelRL do you agree that I can remove the assertion? |
|
Successfully tested in CGAL-6.1-Ic-104 (warning is gone) |
If you go up in the history, there is a bit of back and forth (removed --> use assume --> removed...). Is it clear why the "assume" way failed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
We know that the variable
iwill be set byis_edge(), we try to indicate it with aCGAL_assume()but that does not help the compiler, so let's just initialize it. We get the warning here.I am wondering if the
CGAL_assertion()I have put makes sense.Release Management