Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number types: Add double ceil(NT) #8754

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

afabri
Copy link
Member

@afabri afabri commented Feb 25, 2025

Summary of Changes

Add function double ceil(const NT&).

Release Management

  • Affected package(s): Algebraic_foundations, Number_types
  • Feature/Small Feature (if any):
  • Link to compiled documentation (obligatory for small feature) wrong link name to be changed
  • License and copyright ownership: unchanged

@afabri
Copy link
Member Author

afabri commented Feb 25, 2025

I commented out several test cases in Number_types/test/utilities.cpp, where I do not understand why they do not compile.
I did not address CORE::Expr. Also I have no idea what to put for Sqrt_extension.

@mglisse
Copy link
Member

mglisse commented Feb 26, 2025

The standard function std::ceil returns long double when passed a long double and essentially tries to return the same type as its input. It is only for integers that they decided to force the return type to double, probably for consistency with the historical C behavior.
If you want a function that always returns a double, I think using a different name might be clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants