Update detect_features.h #8765
Open
Update detect_features.h #8765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloriot
reviewed
Mar 3, 2025
Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/detect_features.h
Outdated
Show resolved
Hide resolved
sloriot
reviewed
Mar 3, 2025
Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/detect_features.h
Outdated
Show resolved
Hide resolved
|
Successfully tested in CGAL-6.1-Ic-104 |
sloriot
added
Not yet approved
|
@sloriot Sir, I have mailed you regarding GSoC'25. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This commit addresses a bug in the
detect_vertex_incident_patchesfunction of the Polygon Mesh Processing package (file:Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/detect_features.h). The original implementation only processed vertices that were incident to feature edges, leaving non-feature vertices without any recorded patch IDs. According to the documentation, every vertex should have a property map entry listing the patch IDs of all incident faces.To fix this, the conditional check that restricted processing to feature vertices has been removed. Now, every vertex is examined, and its incident patch IDs are correctly gathered.
Release Management
Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/detect_features.h