Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh_3 - add surface_only() named parameter #8781

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

janetournois
Copy link
Member

Summary of Changes

Add the option surface_only() to make_mesh_3(), to completely skip the "refine_cells" part of Mesh_3, and cancel perturbation and exudation.
@soesau and I noticed that scanning cells, even in the context of "Surface mesher", takes a lot of useless time.

@soesau you can use this branch for your benchmark

@lrineau do you think surface_only should be a member of Mesher_3 or a parameter of Mesher_3::refine_mesh() (as done here)?

Todo: documentation

Release Management

  • Affected package(s): Mesh_3
  • Feature/Small Feature (if any):
  • Link to compiled documentation (obligatory for small feature) wrong link name to be changed
  • License and copyright ownership: unchanged

to completely skip the "refine_cells" part of Mesh_3
@janetournois janetournois self-assigned this Mar 11, 2025
@janetournois janetournois added this to the 6.1-beta milestone Mar 11, 2025
@sloriot
Copy link
Member

sloriot commented Mar 11, 2025

no diff in the PMP header?

@afabri
Copy link
Member

afabri commented Mar 11, 2025

We could also have a function named make_surface_mesh()

@janetournois
Copy link
Member Author

janetournois commented Mar 11, 2025

no diff in the PMP header?

I think it's not needed here. It's a parameter function like features() or mesh_3_dump()

@sloriot
Copy link
Member

sloriot commented Mar 12, 2025

no diff in the PMP header?

I think it's not needed here. It's a parameter function like features() or mesh_3_dump()

OK I thought that you would need to pass the option in the call to make_mesh_3() here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants