Refactoring code in src/user/notifications.js to reduce parameters #5#20
Open
rkkhalif wants to merge 3 commits into
Open
Refactoring code in src/user/notifications.js to reduce parameters #5#20rkkhalif wants to merge 3 commits into
rkkhalif wants to merge 3 commits into
Conversation
rkkhalif
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally, the function had a too many parameters issue. So to tackle this issue, i grouped any related parameters into one object to reduce the overall number of parameters needed. I have also updated any other function that calls this method by fixing the parameters to take in the object rather than 4 individual parameters.
Resolves #5