Skip to content

fixed issue #4: Refactored smell of src/posts/index.js #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fahadabd1 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fixed issue #4: Refactored smell of src/posts/index.js #34

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a77427b
fixed smell of src/posts/index.js file
fahadabd1 Sep 3, 2025
885cc10
removed print
fahadabd1 Sep 3, 2025
4c872fd
Merge branch 'CMU-17313Q:main' into fix-smell
fahadabd1 Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/posts/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,12 @@ Posts.exists = async function (pids) {
);
};

Posts.getPidsFromSet = async function (set, start, stop, reverse) {
Posts.getPidsFromSet = async function (...params) {
const [set, start, stop, reverse] = params;
if (isNaN(start) || isNaN(stop)) {
return [];
}

return await db[reverse ? 'getSortedSetRevRange' : 'getSortedSetRange'](set, start, stop);
};

Expand All @@ -56,7 +58,8 @@ Posts.getPostsByPids = async function (pids, uid) {
return data.posts.filter(Boolean);
};

Posts.getPostSummariesFromSet = async function (set, uid, start, stop) {
Posts.getPostSummariesFromSet = async function (...params) {
const [set, uid, start, stop] = params;
let pids = await db.getSortedSetRevRange(set, start, stop);
pids = await privileges.posts.filter('topics:read', pids, uid);
const posts = await Posts.getPostSummaryByPids(pids, uid, { stripTags: false });
Expand Down