Fixing complexity issues in bookmarks (src/topics/bookmarks.js)#38
Open
nniknam1 wants to merge 5 commits into
Open
Fixing complexity issues in bookmarks (src/topics/bookmarks.js)#38nniknam1 wants to merge 5 commits into
nniknam1 wants to merge 5 commits into
Conversation
Pull Request Test Coverage Report for Build 17518873924Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I resolved this issue: (9 Function with many returns (count = 8): exports) by refactoring the bookmarks.js module by moving inner functions out of the module.exports wrapper into standalone async functions. This eliminated the “function with many returns” Qlty smell and made the code cleaner and easier to maintain. I then verified the changes by running Qlty, lint/tests, and manually triggering the functions in a live NodeBB instance. Resolves #23