Fixing complexity issues in src/coverPhoto.js#43
Open
jeremy-ru wants to merge 3 commits into
Open
Conversation
Pull Request Test Coverage Report for Build 17485555713Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #33
Resolved the issue of high complexity (count = 12) in the getCover function within src/coverPhoto.js by refactoring the logic to get rid of nested if statements. By solving the deeply nested conditional structure, the readability and maintainability is improved. The core functionality for selecting and formatting cover images remains the same as the original version. This change also passed the npm lint and test as well as the Qlty smell issue, resolving #33 and keeping the coverage report to be mostly green.