P1B: Refactor (public/src/client/login.js:init) – reduce function complexity#59
Open
haolinwa wants to merge 1 commit into
Open
P1B: Refactor (public/src/client/login.js:init) – reduce function complexity#59haolinwa wants to merge 1 commit into
haolinwa wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the
Login.initfunction inpublic/src/client/login.js.Extracted helper functions (
bindSubmitHandler,showError,clearError,handleSuccessRedirect,handleAjaxError, etc.) to simplify logic.Reduced function complexity from 13 → below threshold flagged by Qlty.
No behavior changes.
✅ Qlty:
qlty smells public/src/client/login.jsreports no smells.✅ Lint:
npm run lintpassed (0 errors).✅ Tests:
npm run testpassed.✅ Manual validation: temporary
console.log("Haolin Wang: login init triggered")confirmed execution on/loginpage in browser DevTools.Resolves Issue 57