Skip to content

Refactor src/search.js : reduced complexity through the use of helper functions that separated the function into more readable segments #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lsharma-21 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Refactor src/search.js : reduced complexity through the use of helper functions that separated the function into more readable segments #168

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db89ac6
added a helper method for the strings portion to decread the complexity
lsharma-21 Jan 24, 2026
6c24f0a
added a helper method for the strings portion to decread the complexity
lsharma-21 Jan 24, 2026
557fafe
added a helper method for the strings portion to decread the complexi…
lsharma-21 Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions src/search.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,7 @@ function filterByTags(posts, hasTags) {

function sortPosts(posts, data) {
if (!posts.length || data.sortBy === 'relevance') {
console.log('Lata Sharma');
return;
}

Expand All @@ -375,16 +376,24 @@ function sortPosts(posts, data) {
posts.sort((p1, p2) => direction * (p2[fields[0]][fields[1]] - p1[fields[0]][fields[1]]));
} else {
posts.sort((p1, p2) => {
if (p1[fields[0]][fields[1]] > p2[fields[0]][fields[1]]) {
return direction;
} else if (p1[fields[0]][fields[1]] < p2[fields[0]][fields[1]]) {
return -direction;
}
return 0;
sortStringHelper(data, p1, p2);
});
}
}

function sortStringHelper(data, p1, p2) {
data.sortDirection = data.sortDirection || 'desc';
const direction = data.sortDirection === 'desc' ? 1 : -1;
const fields = data.sortBy.split('.');
if (p1[fields[0]][fields[1]] > p2[fields[0]][fields[1]]) {
return direction;

} else if (p1[fields[0]][fields[1]] < p2[fields[0]][fields[1]]) {
return -direction;
}
return 0;
}

async function getSearchCids(data) {
if (!Array.isArray(data.categories) || !data.categories.length) {
return [];
Expand Down