Repository navigation
test(tui): expand repository map coverage - #25
Merged
Merged
Conversation
yswcyswc
force-pushed
the
cathyw/group-edge-tests
branch
from
October 8, 2026 18:37
2aaa230 to
1444c62
Compare
This was referenced Oct 8, 2026
yswcyswc
changed the base branch from
cathyw/group-learning-explanations
to
main
October 8, 2026 21:11
yswcyswc
changed the base branch from
main
to
cathyw/group-learning-explanations
October 8, 2026 21:15
yswcyswc
force-pushed
the
cathyw/group-edge-tests
branch
from
October 8, 2026 21:47
07d3647 to
47084c8
Compare
Contributor
|
Looks good! I like that you added tests for the group limits and made sure files don't get dropped when those limits are reached. One thing we could also test is what happens when the same file is read multiple times in a session. Otherwise, I think this works. |
This was referenced Oct 9, 2026
yswcyswc
changed the base branch from
cathyw/group-learning-explanations
to
main
October 9, 2026 00:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Related to #12. Builds on merged #24.
Type of change
What does this PR do?
The repository map could miss files read in the current session when
readreturned absolute paths, omit those files from model naming examples, or show more than 20 subgroups in the overflow group. This PR fixes those cases, adds focused unit and integration tests, and documents how to use and test/groupinUserGuide.md.How did you verify your code works?
packages/tui/test/util/repository-functionality.test.tschecks layouts, 30-group and 20-subgroup limits, overflow file preservation, prompt bounds, and naming fallback.packages/tui/test/util/referenced-file.test.tschecks completed reads, excluded results, path conversion, and command registration.packages/tui/test/integration/repository-map.test.tspasses session read records through file collection, grouping, and naming/explanation prompts. It checks that repeated reads count once and that a read file remains prompt evidence.UserGuide.mdgives the full Learn-mode workflow; feat(tui): group files based on functionality for repository learning #18 and feat(tui): add context-aware repository group explanations #24 contain UI screenshots and a recording. Automated TUI E2E coverage is added separately in test(tui): verify group map navigation and explanations #29.packages/tui: 225 passed, 1 skipped, 0 failed;bun typecheckandgit diff --checkpassed. CI passed for this PR.These tests match #12's grouping, limits, prioritization, and fallback criteria. The manual workflow checks model output and UI behavior that the unit and integration tests cannot.
Screenshots / recordings
Earlier

packages/tuitest run: 224 passed, 1 skipped, 0 failed. The new integration test brings the current result to 225 passed, 1 skipped, 0 failed.The existing
/grouprecording is linked in #18, and the explanation screenshot is in #24.Checklist