Skip to content

WIP: Date Filtering By Date Controller + Pagination#47

Open
AlexDaGreat555 wants to merge 17 commits into
mainfrom
feature/topic-filtering
Open

WIP: Date Filtering By Date Controller + Pagination#47
AlexDaGreat555 wants to merge 17 commits into
mainfrom
feature/topic-filtering

Conversation

@AlexDaGreat555
Copy link
Copy Markdown

@AlexDaGreat555 AlexDaGreat555 commented Oct 11, 2025

Context:
I was working on the Date Filtering By Date controller such that when the user inputs a date in the date input, that information gets processed and queried in the backend to paginate the topics. Unfortunately it is a bit buggy and needs some tweaking before it is pushed to main

What I did:

  • Edited vendor/nodebb-theme-harmony-2.1.15/templates/category.tpl such that the controller GET action is initiated when the user clicks submit on the date
  • Updated src/controllers/category.js to take into account any data params, then parse and validate, and finally fetch the topics utilizing helper method

Next Steps:

  • I need to revised the controller action because there is a bug where more than the necessary topics show up
Screenshot 2025-10-10 at 11 57 27 PM

…n a given category based on their level of authorization and the given category we are searching within
…d on specific day in specified category. Tested briefly
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 18424027522

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 25 (16.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.08%) to 78.145%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/controllers/category.js 4 25 16.0%
Files with Coverage Reduction New Missed Lines %
src/controllers/admin/info.js 2 71.76%
src/activitypub/index.js 4 55.04%
Totals Coverage Status
Change from base Build 18422444793: -0.08%
Covered Lines: 25046
Relevant Lines: 30138

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants