Skip to content

Fixing lint errors and warnings#34

Open
eseudieu wants to merge 1 commit into
mainfrom
fixing-lint-errors
Open

Fixing lint errors and warnings#34
eseudieu wants to merge 1 commit into
mainfrom
fixing-lint-errors

Conversation

@eseudieu
Copy link
Copy Markdown

Fix lint errors & warnings

Summary

This PR resolves existing lint errors and warnings across the repository by updating code to conform with the project’s ESLint configuration (eslint.config.mjs) and the expected NodeBB style conventions. The changes include:

  • Fixed pattern issues identified by eslint

These changes make the codebase more consistent with the existing linting expectations and should result in the main branch passing the CI check.

Changes

  • Ran the linter and applied automatic and manual fixes (ESLint + project config)
    -- Ran eslint --fix --report-unused-disable-directives .
  • Added .archiver_shadow to eslint's ignore

Testing

After merging this PR, you should be able to:

npm install
npm run lint

Expected result: no lint errors or warnings.

Significance

Linting standards help maintain code quality and consistency, prevent common bugs, and reduce technical debt. Following the repository’s lint rules ensures that contributions remain uniform and easier to review and maintain over time.

Checklist

  • All lint errors fixed
  • All warnings addressed where reasonable
  • Code changes reviewed for logical correctness
  • Builds and tests pass

@eseudieu
Copy link
Copy Markdown
Author

Good test coverage
image

As you can see, no errors reported
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant