Repository navigation
Add /scotty command that displays Scotty ASCII art - #205
Closed
ethantao14 wants to merge 2 commits into
Closed
ethantao14 wants to merge 2 commits into
ethantao14 wants to merge 2 commits into
Conversation
Registers a new built-in TUI command with slashName "scotty" that opens a dialog rendering ASCII art of Scotty the Scottish Terrier. The dialog follows the existing ui/dialog-alert.tsx pattern and closes on esc or enter.
Collaborator
|
FYI: this is the best Scotty I've seen so far today |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #
Type of change
What does this PR do?
How did you verify your code works?
I ran the TUI locally with bun run dev and typed /scotty, and the ASCII art dialog renders as expected. Both esc and enter close it. The command also shows up in the ctrl+p command palette as "Show Scotty" under the System category, and launching it from there works too.
For static checks, oxlint is clean on both changed files and tsgo --noEmit passes for packages/tui. The package test suite passes with 193 pass, 1 skip, 0 fail.
CI is green on commit 826bb52, with unit, typecheck, and e2e smoke all succeeding.
Screenshots / recordings
Checklist
If you do not follow this template your PR will be automatically rejected.