Skip to content

Conversation

@zachcran
Copy link
Contributor

Is this pull request associated with an issue(s)?
Fixes #114.

Description
Includes cmake/cmake_test/asserts/string.cmake in the aggregator file cmake/cmake_test/asserts/asserts.cmake, since the include was missing.

I also reordered the includes in cmake/cmake_test/asserts/asserts.cmake to be sorted in alphabetical order.

@zachcran zachcran self-assigned this May 29, 2025
@zachcran zachcran added the bump:patch Increments the patch version. label May 29, 2025
@zachcran
Copy link
Contributor Author

@ryanmrichard This PR is r2g.

If users are not supposed to be required to add include(cmake_test/cmake_test) to the top of each test file, we may want to consider adding tests that can catch if we missed an include like this. I'm not immediately sure of the best way to do this, so it probably needs some more discussion. Let me know if that is something you want.

ryanmrichard
ryanmrichard previously approved these changes May 30, 2025
Copy link
Contributor

@ryanmrichard ryanmrichard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ryanmrichard
Copy link
Contributor

@zachcran any idea why the tests are failing?

@ryanmrichard
Copy link
Contributor

@zachcran nvm the error is pretty self-explanatory.

@ryanmrichard ryanmrichard merged commit 253dd5b into CMakePP:master Jun 2, 2025
7 checks passed
@zachcran zachcran deleted the 114_fix_assert_string_include branch June 5, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bump:patch Increments the patch version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Unknown CMake command "ct_assert_string"

2 participants