-
Notifications
You must be signed in to change notification settings - Fork 8
feat!: Make array.get
give back the passed array
#2110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: arrays/conversion
Are you sure you want to change the base?
Conversation
array.get
give back the passed array
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## arrays/conversion #2110 +/- ##
=====================================================
- Coverage 83.40% 83.40% -0.01%
=====================================================
Files 226 226
Lines 42440 42444 +4
Branches 38493 38497 +4
=====================================================
+ Hits 35396 35399 +3
- Misses 5225 5226 +1
Partials 1819 1819
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -30,13 +30,13 @@ pub trait ArrayOpBuilder<AK: ArrayKind>: Dataflow { | |||
size: u64, | |||
input: Wire, | |||
index: Wire, | |||
) -> Result<Wire, BuildError> { | |||
) -> Result<(Wire, Wire), BuildError> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It wouldn't hurt to document the trait method saying which output is which.
(none of the other methods have docs though -.-)
Since the array type is now linear following #2097, we need to change the signature of the
array.get
op to give the passed array back to the user.BREAKING CHANGE:
std.collections.array.get
now also returns the passed array as an extra output