Skip to content

Conversation

nriedman
Copy link
Contributor

Finalize SurgeryView UI and refactor HomeView

♻️ Current situation & Problem

The SurgeryView previously did not have room for the "chat" button in the toolbar to bring up the LLM chat assistant. Also, the HomeView code was extremely messy and used disable swiftlint commands to avoid warnings.

⚙️ Release Notes

Got rid of the "edit" button in SurgeryView. Added a "delete" button to the InspectSurgeryView (it is not shown when adding a new surgery). Now, if a user wants to delete a surgery, they can either swipe left on the surgery in SurgeryView or click on it to edit and select the "delete" button. SurgeryView now has a "chat" button in the toolbar to activate the LLM assistant.

📚 Documentation

This is what the new views look like:
Screenshot 2024-03-11 at 12 01 06 AM
Screenshot 2024-03-11 at 12 00 39 AM
Screenshot 2024-03-11 at 12 00 55 AM

✅ Testing

This code will be thoroughly tested along with the rest of the codebase.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@nriedman nriedman enabled auto-merge (squash) March 11, 2024 07:19
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 10.61%. Comparing base (081ea98) to head (48f5edf).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
- Coverage   10.85%   10.61%   -0.23%     
==========================================
  Files          60       60              
  Lines        3365     3375      +10     
==========================================
- Hits          365      358       -7     
- Misses       3000     3017      +17     
Files Coverage Δ
Intake/IntakeDelegate.swift 96.43% <ø> (-0.34%) ⬇️
Intake/Home.swift 92.08% <96.43%> (-0.07%) ⬇️
Intake/Surgery/SurgeryView.swift 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 081ea98...48f5edf. Read the comment docs.

Copy link
Contributor

@kcallon kcallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!!

@nriedman nriedman merged commit 06a8726 into main Mar 11, 2024
@nriedman nriedman deleted the navigation/move-primary-concern branch March 11, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants