Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phone Charge Notification #51

Merged
merged 8 commits into from
Mar 13, 2025
Merged

Phone Charge Notification #51

merged 8 commits into from
Mar 13, 2025

Conversation

jennleww
Copy link
Contributor

@jennleww jennleww commented Mar 11, 2025

Name of the PR

♻️ Current situation & Problem

Currently, the CoughSync app does not provide a reminder for users to keep their phone plugged in while running nighttime cough detection. Since continuous tracking can drain battery life, users might experience interruptions if their device runs out of charge overnight.

This PR introduces a notification pop-up that appears when the user starts cough detection, reminding them to keep their phone plugged in.

⚙️ Release Notes

  • Feature: Added an alert that reminds users to keep their phone plugged in when they start cough detection.
  • Impact: Improves user experience by reducing the chance of tracking interruptions due to battery depletion.

✅ Testing

N/A

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@jennleww jennleww requested a review from MiguelAFH March 11, 2025 23:01
.alert("Keep Your Phone Plugged In", isPresented: $showChargingReminder) {
Button("OK", role: .cancel) {}
} message: {
Text("For accurate cough tracking throughout the night, please keep your phone plugged in and charging.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the message to ask user to keep phone close to their bed.

Copy link
Contributor

@MiguelAFH MiguelAFH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor wording change needed.

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 60.98%. Comparing base (58812e6) to head (0aa3003).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
CoughSync/CoughView/CoughModelView.swift 66.67% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   60.96%   60.98%   +0.02%     
==========================================
  Files          36       36              
  Lines        2031     2037       +6     
==========================================
+ Hits         1238     1242       +4     
- Misses        793      795       +2     
Files with missing lines Coverage Δ
CoughSync/Summary/SummaryView.swift 92.70% <ø> (ø)
CoughSync/CoughView/CoughModelView.swift 51.20% <66.67%> (+1.20%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58812e6...0aa3003. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jennleww jennleww enabled auto-merge (squash) March 12, 2025 03:09
@jennleww jennleww disabled auto-merge March 12, 2025 03:10
@jennleww jennleww enabled auto-merge (squash) March 12, 2025 03:16
@jennleww jennleww merged commit 744a42e into main Mar 13, 2025
10 checks passed
@jennleww jennleww deleted the ChargeNotif branch March 13, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants