Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dark mode #57

Merged
merged 4 commits into from
Mar 14, 2025
Merged

Fix dark mode #57

merged 4 commits into from
Mar 14, 2025

Conversation

MiguelAFH
Copy link
Contributor

Fix dark mode

♻️ Current situation & Problem

Dark mode doesn't work well on the report cards

⚙️ Release Notes

Added support for dark mode on the report cards.

📚 Documentation

✅ Testing

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@MiguelAFH MiguelAFH marked this pull request as ready for review March 13, 2025 22:47
Copy link
Contributor

@EthanRakutoBell EthanRakutoBell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix, well done Miguel

Copy link
Contributor

@jennleww jennleww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix, can now add to documentation!

Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.90%. Comparing base (1d634be) to head (d453fdb).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   72.86%   72.90%   +0.04%     
==========================================
  Files          33       33              
  Lines        2074     2077       +3     
==========================================
+ Hits         1511     1514       +3     
  Misses        563      563              
Files with missing lines Coverage Δ
CoughSync/Report/ReportCard.swift 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d634be...d453fdb. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MiguelAFH MiguelAFH enabled auto-merge (squash) March 14, 2025 02:32
@MiguelAFH MiguelAFH merged commit 08febdb into main Mar 14, 2025
10 checks passed
@MiguelAFH MiguelAFH deleted the dark-mode branch March 14, 2025 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants