Skip to content

Conversation

@Sepante
Copy link
Collaborator

@Sepante Sepante commented Jun 17, 2024

Homophily inference function is added.
Initial tests are added.

@Sepante Sepante requested a review from lisette-espin June 17, 2024 16:38
@mannbach
Copy link
Contributor

@lisette-espin We implemented these changes yesterday. Could you please briefly check if anything needs to be changed? Thanks!

@lisette-espin
Copy link
Contributor

Hi @Sepante, thanks for the update, and sorry for the delay.

I checked the code. Everything looks good, but before we merge the new code, could you please clarify/add the following:

  1. in graph.py
  • please add the proper reference of your paper to the class docstring of the class (under "References")
  • If your method assumes h_MM == h_mm please raise an exception if they are not the same.
  1. For the tests, it would be great if:
  • you set the random seed for reproducibility in all tests.
  • remove the unnecessary comments.
  • If your method assumes h_MM == h_mm please add that as validation too in the tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants