Skip to content

Remove async from CTFd.pages.challenge.checkSolution #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2025
Merged

Remove async from CTFd.pages.challenge.checkSolution #35

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f34525e
Remove async from CTFd.pages.challenge.checkSolution
ColdHeat Oct 29, 2025
f225e5e
Fix solved behavior for checkSolution
ColdHeat Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions pages/challenge.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ export async function getSolution(challengeId) {
}

// Function to check whether the UI should check for a challenge solution
export async function checkSolution(solutionState, challengeData, submissionStatus) {
export function checkSolution(solutionState, challengeData, submissionStatus) {
if (CTFd._functions.challenge.checkSolution) {
return CTFd._functions.challenge.checkSolution(
solutionState,
Expand All @@ -153,8 +153,9 @@ export async function checkSolution(solutionState, challengeData, submissionStat
}
if (solutionState == "hidden" || solutionState == "visible") {
return false;
} else if (solutionState == "solved" && submissionStatus === "correct") {
return true;
} else if (solutionState == "solved") {
// If solutionState is solved we should check if the user got their submission right
return submissionStatus === "correct";
} else {
// We default to true in case there is a solution state that we are not aware of
return true;
Expand Down