Enhancements to QThreadExecutor #152
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the conformity of QThreadExecutor with the Executor protocol.
shutdown()
is now thread-safe and there is no race betweenshutdown()
andsubmit()
.shutdown()
can be called more than once. This is how the standard Executors work, and is congruent withclose()
and similar methods.map()
is supported.cancel_futures
argument toshutdown()
is supported.In addition, a context manager,
closing()
is added, which does ashutdown(wait=False)
by default. This is useful in code likeBecause otherwise a blocking wait for thread completion is performed at the end of the context. It is sufficient to shut down the executor and allow the threads to wake up and stop in their own time, and not force a wait there which can last several milliseconds.