Repository navigation
security(csp): version-safe inline-script nonce wrapper + strengthen PO/MO instructions #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,102 @@ | ||
| <?php | ||
| /* | ||
| +-------------------------------------------------------------------------+ | ||
| | Copyright (C) 2004-2026 The Cacti Group | | ||
| | | | ||
| | This program is free software; you can redistribute it and/or | | ||
| | modify it under the terms of the GNU General Public License | | ||
| | as published by the Free Software Foundation; either version 2 | | ||
| | of the License, or (at your option) any later version. | | ||
| | | | ||
| | This program is distributed in the hope that it will be useful, | | ||
| | but WITHOUT ANY WARRANTY; without even the implied warranty of | | ||
| | MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | | ||
| | GNU General Public License for more details. | | ||
| +-------------------------------------------------------------------------+ | ||
| | Cacti: The Complete RRDtool-based Graphing Solution | | ||
| +-------------------------------------------------------------------------+ | ||
| | This code is designed, written, and maintained by the Cacti Group. See | | ||
| | about.php and/or the AUTHORS file for specific developer information. | | ||
| +-------------------------------------------------------------------------+ | ||
| | http://www.cacti.net/ | | ||
| +-------------------------------------------------------------------------+ | ||
| */ | ||
|
|
||
| /* | ||
| * Unit coverage for plugin_quicktree_csp_nonce(). | ||
| * | ||
| * The helper has two branches that hinge on whether Cacti's global | ||
| * CactiSecureHeaders class is present. A single PHP process can only ever | ||
| * see the class as present or absent, never both, so the class-present | ||
| * branch is exercised in an isolated child process that defines a | ||
| * controlled double, rather than by mutating global state in this process | ||
| * or asserting on the source text. | ||
| */ | ||
|
|
||
| beforeAll(function () { | ||
| require_once __DIR__ . '/../../setup.php'; | ||
| }); | ||
|
|
||
| test('csp nonce returns an empty string when CactiSecureHeaders is unavailable', function () { | ||
| if (class_exists('CactiSecureHeaders')) { | ||
| $this->markTestSkipped('CactiSecureHeaders is present in this runtime; the delegation path is covered by the isolated-process test.'); | ||
| } | ||
|
|
||
| expect(plugin_quicktree_csp_nonce())->toBe(''); | ||
| }); | ||
|
|
||
| test('csp nonce helper is declared to return a string', function () { | ||
| $ref = new ReflectionFunction('plugin_quicktree_csp_nonce'); | ||
|
|
||
| expect((string) $ref->getReturnType())->toBe('string'); | ||
| }); | ||
|
|
||
| test('csp nonce delegates to CactiSecureHeaders when the class is available', function () { | ||
| $wrapper = realpath(__DIR__ . '/../../setup.php'); | ||
| expect($wrapper)->not->toBeFalse(); | ||
|
|
||
| // The wrapper's file may not be loadable in isolation (some plugins | ||
| // include translised arrays at file scope), so hand the child the unit | ||
| // bootstrap too; it defines the Cacti stubs the file needs at load time. | ||
| $bootstrap = realpath(__DIR__ . '/../bootstrap-unit.php'); | ||
|
|
||
| // Run in a clean child process so the double never leaks into the rest | ||
| // of the suite and the delegation branch is genuinely invoked. | ||
| $script = <<<'CHILD' | ||
| <?php | ||
| error_reporting(0); | ||
| ini_set('display_errors', '0'); | ||
|
|
||
| class CactiSecureHeaders { | ||
| public static function getNonceAttribute(): string { | ||
| return ' nonce="pest-controlled-double"'; | ||
| } | ||
| } | ||
|
|
||
| if (isset($argv[2]) && $argv[2] !== '' && is_file($argv[2])) { | ||
| try { require $argv[2]; } catch (\Throwable $e) { /* no Cacti host locally */ } | ||
| } | ||
|
|
||
| require $argv[1]; | ||
|
|
||
| echo "<<<" . plugin_quicktree_csp_nonce() . ">>>"; | ||
| CHILD; | ||
|
|
||
| $tmp = tempnam(sys_get_temp_dir(), 'csp_'); | ||
| expect($tmp)->not->toBeFalse(); | ||
|
|
||
| try { | ||
| file_put_contents($tmp, $script); | ||
|
|
||
| $command = escapeshellarg(PHP_BINARY) . ' ' . escapeshellarg($tmp) . ' ' . escapeshellarg($wrapper) . ' ' . escapeshellarg($bootstrap === false ? '' : $bootstrap); | ||
| $output = shell_exec($command); | ||
|
|
||
| expect($output)->not->toBeNull(); | ||
|
|
||
| preg_match('/<<<(.*)>>>/s', (string) $output, $matches); | ||
| expect($matches)->toHaveKey(1); | ||
| expect($matches[1])->toBe(' nonce="pest-controlled-double"'); | ||
| } finally { | ||
| @unlink($tmp); | ||
| } | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.