Merging All Cacti 1.2.x changes to develop for future development purposes #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Odd Cacti log format issue when script server timeout happened
Probably a copy/paste error, it does not impact the functionality of the script, just throws an error when it is run. Co-authored-by: Erik Sejr <[email protected]>
On FreeBSD when configured with default settings, compilation of spine
will always fail:
```
/bin/sh ./libtool --tag=CC --mode=link cc -I/usr/local/include/net-snmp -I/usr/local/include/net-snmp/.. -I/usr/local/include/mysql -g -O2 -L/usr/local/lib -L/usr/local/lib/mysql -o spine sql.o spine.o util.o snmp.o locks.o poller.o nft_popen.o php.o ping.o keywords.o error.o -lnetsnmp -lmysqlclient_r -lm -ldl -lmysqlclient -lm -ldl -lcrypto -lz -lpthread -ldl -lm -lpthread -lssl
libtool: link: cc -I/usr/local/include/net-snmp -I/usr/local/include/net-snmp/.. -I/usr/local/include/mysql -g -O2 -o spine sql.o spine.o util.o snmp.o locks.o poller.o nft_popen.o php.o ping.o keywords.o error.o -L/usr/local/lib -L/usr/local/lib/mysql -lnetsnmp -lmysqlclient_r -lmysqlclient -lcrypto -lz -ldl -lm -lpthread -lssl
ld: error: undefined symbol: backtrace
>>> referenced by error.c:85
>>> error.o:(spine_signal_handler)
ld: error: undefined symbol: backtrace_symbols
>>> referenced by error.c:86
>>> error.o:(spine_signal_handler)
cc: error: linker command failed with exit code 1 (use -v to see invocation)
*** Error code 1
Stop.
```
When the configure script is run it correctly shows that backtraces are
not supported on this platform:
```
...
checking whether we are using traditional popen... no
checking whether to verify net-snmp library vs header versions... no
checking if we can support backtracing... no
checking if we can support mysql/mariadb retry count... no
checking if we can support mysql/mariadb ssl keys... yes
...
```
And yet in config/config.h we have HAVE_EXECINFO_H defined:
```
/* Do we have backtracing capabilities? */
#define HAVE_EXECINFO_H 1
```
This is because of an error in configure.ac where the value of
HAVE_EXECINFO_H is set twice, the first time by
AC_CHECK_HEADERS(execinfo.h) which returns true (The FreeBSD system does
have execinfo.h, it just does not support the function used here) and a
2nd time later on by a AC_LINK_IFELSE:
```
# See if we can support backtracing
AC_MSG_CHECKING([if we can support backtracing])
AC_LINK_IFELSE([AC_LANG_PROGRAM([[
#include <stdlib.h>
#include <execinfo.h>
]], [[
void *array[10];
size_t size;
// get void*'s for all entries on the stack
size = backtrace(array, 10);
if (size) {
exit(0);
} else {
exit(1);
}
]])],[ AC_MSG_RESULT(yes)
AC_DEFINE(HAVE_EXECINFO_H,1,[Do we have backtracing capabilities?])
],[AC_MSG_RESULT(no)
])
```
Even though the above AC_LANG_PROGRAM fails on FreeBSD, because of the
earlier AC_CHECK_HEADERS succeeding HAVE_EXECINFO_H is already defined
and remains that way leading to the compilation failure.
Since the AC_LANG_PROGRAM check here seems more thorough then the simple
header check and will fail anyway if execinfo.h does not exist I think
the correct course of action here is to remove the AC_CHECK_HEADERS
macro for this particular header completely.
Co-authored-by: Erik Sejr <[email protected]>
This relates to cacti/#5356
-feature: Do not sort by snmp port if you only have snmp on one port -feature: Order Devices by their number of poller items and Device Threads -issue: Remove legacy setting device_threads_exist
- Function strip_alpha() does not strip non-numeric leading characters - GitHub merge created an issue with switch syntax.
The plus sign is redundant
Spine should see if script to be executed is executable
At least it'll work for a /usr/bin/ install path
Spine won't work with complex SNMP results #v2
WARNING: MYSQL_OPT_RECONNECT is deprecated and will be removed in a future version.
Spine does not check a host with no poller items
Wrong number of devices in stats due to device 0 assumption
I actually think this one should be an unsigned long int instead of just a long int. --------- Co-authored-by: Erik Sejr <[email protected]> Co-authored-by: TheWitness <[email protected]>
While compiling sql.c clang 16 generates the following warning:
```
sql.c:407:27: warning: comparison of address of 'db_pool_local[id].mysql' not equal to a null pointer is always true [-Wtautological-pointer-compare]
if (&db_pool_local[id].mysql != NULL) {
~~~~~~~~~~~~~~~~~~^~~~~ ~~~~
sql.c:428:28: warning: comparison of address of 'db_pool_remote[id].mysql' not equal to a null pointer is always true [-Wtautological-pointer-compare]
if (&db_pool_remote[id].mysql != NULL) {
~~~~~~~~~~~~~~~~~~~^~~~~ ~~~~
```
If the conditional is always true then the fix is to remove the
conditional in this instance
Co-authored-by: Erik Sejr <[email protected]>
Co-authored-by: Rich <[email protected]>
Prepare for 1.2.28 release.
Update copyright
TheWitness
changed the title
cigamit
approved these changes
Oct 31, 2024
|
Closing this due to a snafu on my part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting all 1.2.x changes to develop.