task: drain jobs and proxy streams on graceful shutdown#351
Merged
greatest0fallt1me merged 1 commit intoMay 27, 2026
Merged
Conversation
|
@Bug-Hunter-X Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR improves graceful shutdown handling in
src/index.tsso the backend drains in-flight gateway proxy requests and background webhook work before database resources are closed. It introduces coordinated shutdown hooks for drainable subsystems, preserves the existing single-executionprocess.once(...)behavior, and keeps termination bounded by the configured drain window.Related Issue
Closes #334
Changes
⚙️ Graceful Shutdown Coordination
src/index.ts/v1/calltracker so active gateway proxy requests can finish within the drain window.🌐 Proxy Drain Handling
src/index.ts🪝 Webhook Dispatcher Draining
src/webhooks/webhook.dispatcher.ts🧪 Tests
[MODIFY]
src/index.test.tsAdded coverage for subsystem drain ordering.
Added coverage for socket destruction after timeout.
Added coverage that repeated signals reuse the same shutdown flow.
Added coverage for active proxy request draining.
[MODIFY]
src/webhooks/webhook.dispatcher.test.tsAdded coverage that new webhook deliveries are skipped after shutdown begins.
📘 Documentation
README.mdVerification Results
Screenshots
✅ Graceful shutdown tests pass
A screenshot of:
npm test -- src/index.test.tsnpm test -- src/webhooks/webhook.dispatcher.test.ts