-
Notifications
You must be signed in to change notification settings - Fork 14
Firefly-1469: Update DCE to support rubin needs #1742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fc44c82
to
66db591
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good but I found a couple of issues with the UI:
- The data products doesn't load for any row in the search results of collection search
- When I choose "Load as Table" radio option in upload panel, the resulting table's 1st row's data product has embedded search panel - is this expected? If yes, the styling needs to be fixed, the fields are truncated because of limited real estate.
- The Collection Search's layout styles can be improved:
- Search radius looks odd because it's taking full width
- em_ops field looks like it's part of Spectral coverage panel when expanded but it's not. It can use some vertical spacing to create visual separation or move it on top of Spectral coverage panel.
- Can we make Cone/Polygon part of the spatial search panel - see how LVF obscore search form in spherex does it? (I'm not sure if it's feasible here but the idea is UI looks much cleaner because everything is in their own collapsible)
{childComponents && childComponents} | ||
</Stack>) | ||
: undefined; //to avoid rendering empty div (that takes spacing in Stack) | ||
{childComponents && childComponents} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{childComponents && childComponents} | |
{childComponents} |
If it's undefined or anything not of node type, react won't render it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I will fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will fix it.
I meant to mention that the URLs were broken for SIA searches. This is a rubin backend issue
Yes, it is part of the general service descriptor handling which almost never happens in normal use cases. A end user is not going to upload a datalink file either. It is building a UI from the service descriptor. |
03a5d6c
to
1b26aee
Compare
That was just a test field, just to proved it worked. I meant to remove it frem the test. |
I will clean that up.
I don't think it is a good idea in the context. It is always required and can't be turned off. I am trying to clean up the layout. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Search radius looks odd because it's taking full width
I will clean that up.
Can we make Cone/Polygon part of the spatial search panel - see how LVF obscore search form in spherex does it? (I'm not sure if it's feasible here but the idea is UI looks much cleaner because everything is in their own collapsible)
I don't think it is a good idea in the context. It is always required and can't be turned off. I am trying to clean up the layout.
@robyww thanks - it looks more clear now with centered layout that this spatial fields are constant and rest of the fields below it are additional options.
We can iterate more over the design as when we work on improving Embedded search position panel's layout in future.
- support sia wavelength - support sia obscore options using ObsCore panel - support dataServiceId - clean up - improve UI layout - refactor some of DynComponents - included ServiceDescriptorPanel in the improvements - includes response to feedback
1b26aee
to
57244d3
Compare
Firefly-1469: Update DCE to support rubin needs
Testing
more-sia.xml.zip