FIREFLY-1727: Handle Redis failure #1754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Try to reconnect until Redis is back online - Show error status to client - Show status in ServerStatus page - Refactor LostConnection.jsx component to use JoyUI
robyww
approved these changes
May 6, 2025
| } | ||
| throw new ConnectException("Unable to connect to Redis at " + redisHost + ":" + REDIS_PORT); | ||
| String status = failSince == null ? "OK" : | ||
| "Failed since " + DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm:ss").withZone(ZoneId.systemDefault()).format(failSince); |
There was a problem hiding this comment.
I am not looking it up but I would think
withZone(ZoneId.systemDefault()would have a default.
src/firefly/js/core/AppDataCntlr.js
Outdated
| @@ -210,6 +221,10 @@ export function isAppReady() { | |||
| return get(flux.getState(), [APP_DATA_PATH, 'isReady']); | |||
| } | |||
|
|
|||
| export function getConnectionStatus() { | |||
| return get(flux.getState(), [APP_DATA_PATH, 'connectionStatus']); | |||
There was a problem hiding this comment.
why not
flux.getState()?.[APP_DATA_PATH]?.connectionnStatusI find get to not be very readable and unnecessary these days.
| const clzName = decor === 'small' ? 'lost-connection--small' : 'lost-connection'; | ||
| const msg = 'You are no longer connected to the server. Try reloading the page to reconnect.'; | ||
| if (decor !== 'full') return <div className = {clzName} title = {msg} />; | ||
| export function LostConnection () { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://jira.ipac.caltech.edu/browse/FIREFLY-1727
Test: https://fireflydev.ipac.caltech.edu/firefly-1727-handle-redis-failure/firefly/
It's a bit harder to test. To simulate Redis down, I've deployed this instance with 2 replicas.
Locally:
-Dredis.host=127.0.0.1to Tomcat'sbin/setenv.shto see how it behaves when Redis is down.