Merged
Conversation
Closed
There was a problem hiding this comment.
Pull Request Overview
This PR refactors page layout styles and adds Storybook stories for multiple pages. The refactoring consolidates shared styling patterns into reusable components and updates layout implementations across various pages.
- Removed redundant layout components and consolidated styling into shared UI utilities
- Updated Header component to use extracted blur and compound variant styling
- Added Storybook stories for login, signup, landing, and 404 pages
Reviewed Changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/widgets/header/ui/index.tsx | Updated to use shared blur styling and improved compound variants |
| src/widgets/footer/ui/footer.tsx | Refactored to use shared hero styling pattern |
| src/widgets/basic-layout/ | Removed entire basic layout component |
| src/widgets/auth-layout/ui/ | Simplified to use shared layout styling |
| src/shared/ui/styles.ts | Added new shared styling utilities for common patterns |
| src/shared/ui/logo.tsx | Added width fit styling |
| src/shared/ui/hero.tsx | Updated prop naming and background handling |
| src/pages/ | Updated pages to use new layout patterns and added Storybook stories |
| src/app/styles/globals.css | Added Cal Sans font and removed redundant hero class |
| .storybook/preview.tsx | Added HeroUI provider and Next.js configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Merge 시 commit 메시지 맨 앞에 🔀 이모지(
:twisted_rightwards_arrows:)를 붙여주세요!작업 요약