Repository navigation
fix(web): count the same videos the dashboard lists - #2818
Merged
richiemcilroy merged 2 commits intoOct 22, 2026
Merged
Conversation
Contributor
Author
|
@greptileai review |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Member
|
@greptileai review |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the dashboard's page count came from a separate count query that didn't pick the same videos as the list. my caps counted videos that live inside folders even though the list only shows ones outside folders, and the organization caps page checked the video's personal folder instead of the folder it was shared into. so after moving videos into folders the totals and page numbers were off, with empty trailing pages.
now each count uses the same folder filter as its list. two one line filter changes, with tests that run the real page loaders and check the generated queries.
The PR appears safe to merge; both count changes match their lists’ folder filters.Summary
The PR fixes folder filters in dashboard pagination counts.
Reviews (1) · Last reviewed commit: "fix(web): match dashboard pagination cou..." · Reviewed by Greptile