Repository navigation
fix(desktop-gpui): keep caption word timings consistent after text edits - #2833
Merged
richiemcilroy merged 2 commits intoOct 22, 2026
Merged
Conversation
Contributor
Author
|
@greptileai review |
Contributor
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
@greptileai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when you edit a caption's text and the word count changes, the words got a mix of timings: the first ones kept their old times and the rest got evenly spaced slots. added words could start before the previous one ended, so the highlight jumped around, and removing words left the last one ending early so the caption finished before its segment did. the old app had the same mix.
now when the word count changes all the words are spaced evenly across the caption, which is the policy the helper already used for the new words. edits that keep the same number of words, like fixing a spelling, still keep the original per word timing. captions oracles pass.


Confidence Score: 5/5
This PR appears safe to merge.Summary
Updates
sync_caption_words_with_textto spread every word evenly across the caption when the word count changes.Reviews (1) · Last reviewed commit: "fix(desktop-gpui): keep caption word tim..." · Reviewed by Greptile