Skip to content

fix(desktop-gpui): keep caption word timings consistent after text edits - #2833

Merged
richiemcilroy merged 2 commits into
CapSoftware:mainfrom
yashranaway:fix/caption-word-retiming
Oct 22, 2026
Merged

richiemcilroy merged 2 commits into
CapSoftware:mainfrom
yashranaway:fix/caption-word-retiming

Conversation

@yashranaway

@yashranaway yashranaway commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

when you edit a caption's text and the word count changes, the words got a mix of timings: the first ones kept their old times and the rest got evenly spaced slots. added words could start before the previous one ended, so the highlight jumped around, and removing words left the last one ending early so the caption finished before its segment did. the old app had the same mix.

now when the word count changes all the words are spaced evenly across the caption, which is the policy the helper already used for the new words. edits that keep the same number of words, like fixing a spelling, still keep the original per word timing. captions oracles pass.

RetriggerView in GreptileConfidence Score: 5/5

This PR appears safe to merge.

Summary

Updates sync_caption_words_with_text to spread every word evenly across the caption when the word count changes.

  • Caption words now share the available time when their count changes.

Reviews (1) · Last reviewed commit: "fix(desktop-gpui): keep caption word tim..." · Reviewed by Greptile

@yashranaway

Copy link
Copy Markdown
Contributor Author

@greptileai review

@vercel

vercel Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

@richiemcilroy

Copy link
Copy Markdown
Member

@greptileai review

@richiemcilroy
richiemcilroy merged commit f93e89e into CapSoftware:main Oct 22, 2026
35 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants