Repository navigation
fix(cli): upload videos without requiring --name - #2841
Merged
richiemcilroy merged 2 commits intoOct 22, 2026
Merged
Conversation
Contributor
|
@AksharP5 is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
@greptileai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uploading a video with agent login or a CLI API key fails unless
--nameis supplied, even though the flag is optional. The CLI sendstitle: null, which the API rejects before creating an upload.Omit the title when no name was requested so the server can use its existing filename fallback. Keep explicit names intact.
Closes #2840
Before and after
Same synthetic MP4 and production upload routine/client, with schema-validated loopback HTTP fixtures:
cap upload demo.mp4title: null; schema rejects; no file transferdemocap upload demo.mp4 --name DemoDemocap upload demo.mp4 --name ""Successful cases transfer all 697,470 bytes with matching SHA-256 checksums.
Validation
git diff --checkpass.cargo check -p cap --offline --lockedis blocked in the unchanged FFmpeg dependency by the missinglibavcodec/avfft.hheader. Full CLI tests and other platforms were not run locally.The HTTP proof runs the production upload routine and
AgentClient, with controlled authentication, storage, database, and processing responses. Its API schema expression uses cached Effect 3.22.1; the repository locks 3.21.4. FFmpeg probing and live cloud services are outside this harness.

Confidence Score: 5/5
The PR appears safe to merge.Summary
Fixes agent-authenticated CLI uploads without
--nameby omittingtitleinstead of sending null.--name.Reviews (1) · Last reviewed commit: "fix(cli): upload videos without requirin..." · Reviewed by Greptile