Skip to content

fix(cli): upload videos without requiring --name - #2841

Merged
richiemcilroy merged 2 commits into
CapSoftware:mainfrom
AksharP5:fix/cli-upload-without-name
Oct 22, 2026
Merged

richiemcilroy merged 2 commits into
CapSoftware:mainfrom
AksharP5:fix/cli-upload-without-name

Conversation

@AksharP5

@AksharP5 AksharP5 commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Uploading a video with agent login or a CLI API key fails unless --name is supplied, even though the flag is optional. The CLI sends title: null, which the API rejects before creating an upload.

Omit the title when no name was requested so the server can use its existing filename fallback. Keep explicit names intact.

Closes #2840

Before and after

Same synthetic MP4 and production upload routine/client, with schema-validated loopback HTTP fixtures:

Command Main This PR
cap upload demo.mp4 title: null; schema rejects; no file transfer Title omitted; file transfer and completion succeed; title defaults to demo
cap upload demo.mp4 --name Demo Completes with title Demo Identical requests and result
cap upload demo.mp4 --name "" Completes with filename-derived title Identical requests and result

Successful cases transfer all 697,470 bytes with matching SHA-256 checksums.

Validation

  • The focused optional-title regression test fails against the original serialization and passes with this change. It covers absent, explicit, and empty names.
  • Production-source upload harness builds and Clippy passes with the repository's denied lints. Formatting and git diff --check pass.
  • Full cargo check -p cap --offline --locked is blocked in the unchanged FFmpeg dependency by the missing libavcodec/avfft.h header. Full CLI tests and other platforms were not run locally.

The HTTP proof runs the production upload routine and AgentClient, with controlled authentication, storage, database, and processing responses. Its API schema expression uses cached Effect 3.22.1; the repository locks 3.21.4. FFmpeg probing and live cloud services are outside this harness.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge.

Summary

Fixes agent-authenticated CLI uploads without --name by omitting title instead of sending null.

  • Agent uploads use the filename when you skip --name.

Reviews (1) · Last reviewed commit: "fix(cli): upload videos without requirin..." · Reviewed by Greptile

@vercel

vercel Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

@AksharP5 is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

@richiemcilroy

Copy link
Copy Markdown
Member

@greptileai review

@richiemcilroy
richiemcilroy merged commit 6e1223d into CapSoftware:main Oct 22, 2026
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI uploads fail when --name is omitted

2 participants