[YoavLevavi]

A History button next to Undo/Redo in the editor header lists every undo step, newest first, and jumps straight to one when clicked.

• ProjectHistory keeps a label next to each snapshot, made by diffing it with the previous one ("Added zoom", "Deleted text", "Split clip", "Changed background"...). Labels follow the same truncation and 100-entry limit as the snapshots.
• ProjectHistory::jump_to moves the cursor directly. Steps after the cursor stay redoable and are dimmed in the menu.
• The dropdown follows the Presets menu (backdrop click and Escape close it). Adds icons/history.svg (Lucide).

Testing: cargo test --bin cap-gpui (new history_labels_steps_and_jumps_between_them).

🤖 Generated with Claude Code

Confidence Score: 5/5

The PR appears safe to merge; all previous findings are addressed.

Summary

Adds a History menu with named undo steps and direct jumps between saved states.

• Project history labels saved edits and jumps directly to a chosen snapshot.
• The editor’s History menu lets people pick a labelled project snapshot.

All four previous findings are addressed. No new actionable issues were found. Tests and visual checks were not run.

_{Reviews (3) · Last reviewed commit: "History menu: close it when the history ..." · Reviewed by Greptile}

[YoavLevavi]

@greptileai

[vercel]

@YoavLevavi is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

[richiemcilroy]

Thanks @YoavLevavi, a jumpable history list is a nice touch, and the bookkeeping is solid: labels is truncated, drained and pushed in lockstep with entries, and jump_to keeps the redo tail. Two things before this can go in. 1) open_history_menu and render_history_menu were inserted between render_presets_menu and its doc comment (apps/desktop-gpui/src/editor_window.rs:8773), so that PresetsDropdown.tsx comment now documents open_history_menu. Please move the new functions above that comment. 2) describe_change (apps/desktop-gpui/src/editor_edits.rs:270) labels the first changed key in alphabetical order, but clip deletes ripple every other track (ripple_delete_output_tracks), and audioSegments, camera3dSegments, captionSegments and imageSegments all sort before segments. So deleting a clip with music or an image after it is labelled "Edited audio clip" or "Edited image", and a delete that removes a caption reads "Deleted caption". Could you check segments (and transitions) first, then prefer a key whose count changed over one that only shifted? A test for a clip delete that also shifts an audio segment would cover it. Optional: record now serializes two full configs to JSON on every entry, including in the screenshot editor, which never shows labels. Working out the labels when the menu opens would avoid that cost.

[YoavLevavi]

Thanks @richiemcilroy, both are in 427befa (also merged main), plus the optional one:

1. open_history_menu and render_history_menu now sit above the presets menu's doc comment.
2. describe_change checks segments and transitions first, then prefers a track whose segment count changed over one that only shifted. a_clip_delete_is_labelled_as_one_even_when_it_shifts_other_tracks covers a clip delete that shifts music and drops a caption ("Deleted clip"), and a caption delete next to a shifted audio clip ("Deleted caption").
3. Labels are now worked out only when the menu opens, from consecutive snapshots. record no longer serializes anything, which also fits main's new serializes_equal resume check. When the limit trims the oldest entries, the first label reads "Earlier changes".

@greptileai review

[greptile-apps]

History rows target wrong steps

The menu keeps its original labels and row indices even when keyboard edits change the history. For example, open History, undo, then press C inside a clip. The split replaces the redo branch, but the menu still shows that branch's old labels. Clicking one can restore a different state or do nothing. Close or refresh the menu whenever the history changes.

Prompt To Fix With AI

This is a comment left during a code review.
Path: apps/desktop-gpui/src/editor_window.rs
Line: 9151

Comment:
**History rows target wrong steps**

The menu keeps its original labels and row indices even when keyboard edits change the history. For example, open History, undo, then press `C` inside a clip. The split replaces the redo branch, but the menu still shows that branch's old labels. Clicking one can restore a different state or do nothing. Close or refresh the menu whenever the history changes.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

[greptile-apps]

History copies timelines unnecessarily

describe_change deep-copies both timeline maps even though it only reads them. Opening History repeats this for up to 99 snapshot pairs, after already turning both projects into JSON trees. Caption-heavy projects therefore copy all timeline captions and words again just to open the menu. Borrow the maps instead.

Prompt To Fix With AI

This is a comment left during a code review.
Path: apps/desktop-gpui/src/editor_edits.rs
Line: 295-299

Comment:
**History copies timelines unnecessarily**

`describe_change` deep-copies both timeline maps even though it only reads them. Opening History repeats this for up to 99 snapshot pairs, after already turning both projects into JSON trees. Caption-heavy projects therefore copy all timeline captions and words again just to open the menu. Borrow the maps instead.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

[greptile-apps]

Added comments repeat the code

This comment only restates HISTORY_MENU_WIDTH. AGENTS.md explicitly bans comments that narrate code and requires non-obvious context instead. Remove this narration, along with the similar comments on history_menu and jump_to_history. This repository requirement must be satisfied before merging.

Context Used: AGENTS.md (source)

Prompt To Fix With AI

This is a comment left during a code review.
Path: apps/desktop-gpui/src/editor_window.rs
Line: 206

Comment:
**Added comments repeat the code**

This comment only restates `HISTORY_MENU_WIDTH`. `AGENTS.md` explicitly bans comments that narrate code and requires non-obvious context instead. Remove this narration, along with the similar comments on `history_menu` and `jump_to_history`. This repository requirement must be satisfied before merging.

**Context Used:** AGENTS.md ([source](https://github.com/capsoftware/cap/blob/main/AGENTS.md))

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

[greptile-apps]

Bounds use the prohibited form

The new position calculation uses .min(...).max(12.), which AGENTS.md explicitly forbids in favor of clamp. Use clamp and ensure its upper bound is at least 12. so very narrow windows remain safe. This repository requirement must be satisfied before merging.

Suggested change

	let x = f32::from(anchor.x)
	.min(f32::from(viewport.width) - HISTORY_MENU_WIDTH - 12.)
	.max(12.);
	let x = f32::from(anchor.x).clamp(
	12.,
	(f32::from(viewport.width) - HISTORY_MENU_WIDTH - 12.).max(12.),
	);

Context Used: AGENTS.md (source)

Prompt To Fix With AI

This is a comment left during a code review.
Path: apps/desktop-gpui/src/editor_window.rs
Line: 9145-9147

Comment:
**Bounds use the prohibited form**

The new position calculation uses `.min(...).max(12.)`, which `AGENTS.md` explicitly forbids in favor of `clamp`. Use `clamp` and ensure its upper bound is at least `12.` so very narrow windows remain safe. This repository requirement must be satisfied before merging.

```suggestion
        let x = f32::from(anchor.x).clamp(
            12.,
            (f32::from(viewport.width) - HISTORY_MENU_WIDTH - 12.).max(12.),
        );
```

**Context Used:** AGENTS.md ([source](https://github.com/capsoftware/cap/blob/main/AGENTS.md))

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

[YoavLevavi]

Done in dc784ac: removed the narrating comments on HISTORY_MENU_WIDTH, history_menu, jump_to_history, the History menu render and the ProjectHistory cursor/jump methods. The comments that stay explain why (on-demand labels, trimmed history, label priority).

@greptileai review

[richiemcilroy]

Thanks! Can you get Greptile to 5/5? Then we'll take a look.

[YoavLevavi]

@greptile-apps review

[richiemcilroy]

Thanks! Can you rebase on main to clear the conflicts and resolve the open review threads? Then we'll take a look.