Repository navigation
fix(render-farm): time out hung coordinator audio engines - #2888
Merged
richiemcilroy merged 2 commits intoOct 22, 2026
Merged
Conversation
Contributor
Author
|
@greptileai review |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when the render farm coordinator renders an audio section itself, it waited on the engine with no deadline. if that engine hung, the job sat there and the audio lane stayed taken for good, so every later local audio section queued behind it.
the worker already kills a hung audio engine after a third of the section's length (at least a minute), so the coordinator now uses the same deadline. the killed engine gets replaced on next use and the existing retry and backoff handle the job. tests cover a hung engine and the next job getting a fresh one.
The PR appears safe to merge; no actionable issues were found.Summary
The coordinator now stops hung local audio engines instead of letting them hold a lane indefinitely.
Reviews (1) · Last reviewed commit: "fix(render-farm): time out hung coordina..." · Reviewed by Greptile