Repository navigation
fix(web): restore preview audio after short cuts - #2894
Merged
Merged
Conversation
Contributor
Author
|
@greptileai review |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the web editor preview mutes just before a cut so you don't hear a blip, and only unmuted after the seek past the cut finished. if no seek happened, because the cut was shorter than the 40 ms skip threshold or a delayed frame had already landed past it, nothing unmuted and the rest of the preview played silent. short cuts are common after removing filler words from the transcript.
now audio comes back once playback is inside kept footage and not seeking. the skip threshold is unchanged. tests cover a short cut, a frame landing past a cut, and mute staying on while a seek is pending.
The PR appears safe to merge.Summary
Restores preview audio when playback reaches kept footage without a seek.
Reviews (1) · Last reviewed commit: "fix(web): restore preview audio after sh..." · Reviewed by Greptile