Repository navigation
fix(web): revalidate Cap pages after mobile password changes - #2901
Merged
Merged
Conversation
Contributor
Author
|
@greptileai review |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setting or removing a cap's password from the mobile app updated the database but didn't revalidate anything, so the dashboard lists and the share page kept showing the old protection state until something else refreshed them. the web password action already revalidates those three paths.
now the mobile handler revalidates the same ones (caps, shared caps and the share page) right after the update, like the web action and the mobile title handler do. the test calls the real handler and checks the paths, plus that a wrong owner still can't change it.
The PR appears safe to merge; no actionable issues were found.Summary
Mobile password changes now revalidate the dashboard lists and share page after the database update.
Reviews (1) · Last reviewed commit: "fix(web): revalidate Cap pages after mob..." · Reviewed by Greptile