[yashranaway]

on linux, a window was matched to whichever display contained its centre point. move a window so its centre is off screen, or sitting in the gap between two monitors, and it dropped out of the window picker even though most of it was still visible.

now a window goes to the display it overlaps the most, and only disappears once none of it is on any display. the xvfb test moves a real window half off screen and checks it's still listed, plus unit tests for monitor gaps and two displays.

note: #2816 adds a second copy of the centre point check in its x11 snapshot parser, so whichever of the two lands second should switch that path to this overlap helper too.

Confidence Score: 5/5

The PR appears safe to merge, with the previous CI coverage gap addressed.

Summary

The PR keeps partially visible X11 windows selectable by choosing the display with the largest overlap.

• Partly visible Linux windows stay selectable.

_{Reviews (2) · Last reviewed commit: "test(scap-targets): run X11 target regre..." · Reviewed by Greptile}

[vercel]

@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

[yashranaway]

@greptileai review

[greptile-apps]

CI skips the regression test

The new X11 test is marked #[ignore], but no CI job runs it with --ignored. The existing Xvfb job runs only cap-gpui tests, so a change that breaks window selection can pass CI without exercising this test.

Add a Linux CI step that runs xvfb-run -a cargo test --locked -p scap-targets --test linux_targets -- --ignored.

Prompt To Fix With AI

This is a comment left during a code review.
Path: crates/scap-targets/tests/linux_targets.rs
Line: 14

Comment:
**CI skips the regression test**

The new X11 test is marked `#[ignore]`, but no CI job runs it with `--ignored`. The existing Xvfb job runs only `cap-gpui` tests, so a change that breaks window selection can pass CI without exercising this test.

Add a Linux CI step that runs `xvfb-run -a cargo test --locked -p scap-targets --test linux_targets -- --ignored`.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

[yashranaway]

fair, fixed in 09a22a2. the test now starts its own Xvfb, isn't ignored anymore, and runs in the existing linux desktop regression step. checked it fails with the old window selection and passes with the fix.

[richiemcilroy]

Thanks @yashranaway, the fix looks right to us. Greptile's 4/5 is about coverage: the new X11 test in crates/scap-targets/tests/linux_targets.rs is #[ignore] and no CI job runs it with --ignored. Could you add a step to the existing Linux Xvfb job that runs xvfb-run -a cargo test --locked -p scap-targets --test linux_targets -- --ignored, then comment @greptileai review? Thanks!

[richiemcilroy]

@greptileai review