Skip to content

fix(desktop-gpui): drive camera size during zoom from the rendered scale - #2908

Merged
richiemcilroy merged 2 commits into
CapSoftware:mainfrom
yashranaway:fix/sidebar-slider-values
Oct 23, 2026
Merged

richiemcilroy merged 2 commits into
CapSoftware:mainfrom
yashranaway:fix/sidebar-slider-values

Conversation

@yashranaway

@yashranaway yashranaway commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

the camera "size during zoom" slider in the editor sidebar doesn't do anything. a january renderer change started sizing the camera during zooms from the scale setting (the one the "keep original size during zoom" toggle flips), but the slider kept writing the older zoom size field that nothing reads anymore.

now the slider reads and writes that scale as a percentage, 10 to 100, so it matches what renders and agrees with the toggle (keeping original size shows 100). old projects just show their real scale, 70 by default. added a test for the read side and updated the range test. editor tabs tests and the editing verify suite pass, but i haven't dragged it in the app on mac or windows.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; no actionable issues were found.

Summary

Connects the camera’s “Size During Zoom” slider to scale_during_zoom, which the renderer already uses.

  • The zoom-size slider follows the camera scale used during zooms.

Reviews (1) · Last reviewed commit: "fix(desktop-gpui): drive camera size dur..." · Reviewed by Greptile

@vercel

vercel Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

@yashranaway

Copy link
Copy Markdown
Contributor Author

@greptileai review

@richiemcilroy
richiemcilroy merged commit c6381a6 into CapSoftware:main Oct 23, 2026
35 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants