Repository navigation
fix(desktop-gpui): drive camera size during zoom from the rendered scale - #2908
Merged
richiemcilroy merged 2 commits intoOct 23, 2026
Merged
Conversation
Contributor
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@greptileai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the camera "size during zoom" slider in the editor sidebar doesn't do anything. a january renderer change started sizing the camera during zooms from the scale setting (the one the "keep original size during zoom" toggle flips), but the slider kept writing the older zoom size field that nothing reads anymore.
now the slider reads and writes that scale as a percentage, 10 to 100, so it matches what renders and agrees with the toggle (keeping original size shows 100). old projects just show their real scale, 70 by default. added a test for the read side and updated the range test. editor tabs tests and the editing verify suite pass, but i haven't dragged it in the app on mac or windows.


Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
Connects the camera’s “Size During Zoom” slider to
scale_during_zoom, which the renderer already uses.Reviews (1) · Last reviewed commit: "fix(desktop-gpui): drive camera size dur..." · Reviewed by Greptile