Repository navigation
fix: handle long titles and large Loom downloads - #3008
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two otherwise accessible Loom sources failed during the migration recovery: a 383-character title exceeded the video-name column, and a 2 GB MP4 exceeded the ten-minute download timeout.
Bound newly imported Loom titles to 255 Unicode code points before insertion. Give byte-limited Loom downloads the existing thirty-minute upper bound used for streaming downloads. The 10 GB input limit, ordinary download timeout, owner, destination and source mapping behavior remain unchanged.
Validation: the new long-title, Unicode and bounded-download timeout cases fail against the previous implementation and pass with this change. All 117 focused web import tests and 121 media tests pass, including byte limits, cancellation, recording verification and ordinary download timeout coverage. Repository typechecking and scoped Biome checks pass. The standalone media typecheck reports seven identical errors on main and this branch, all in untouched files. Production recovery will reuse the existing failed recording and retry the title rejection only after reconciling the previous attempts.