Repository navigation
perf(media-server): parallelise recording verification behind opt-in env settings - #3009
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Member
Author
|
@greptileai review |
…erification fallback
Member
Author
|
@greptileai review |
This was referenced Oct 23, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desktop recordings spend most of their media-server time in verification. On an 8 vCPU worker a 5-minute recording takes ~30s to verify, and almost all of that is one H.264 decode that stops scaling at ~6 cores. This makes verification parallel without changing what it checks. Everything new is behind env settings that default to today's behaviour.
What changes
MEDIA_SERVER_VERIFY_DECODE_CHUNKS, off by default).-xerror,-err_detect explode+crccheck).validateEvidence.MEDIA_SERVER_VERIFY_DOWNLOAD_CONCURRENCY, off by default).If-Matchand its ETag andContent-Rangeare checked.Rangefalls back to the sequential read.Measured. Test boxes with the desktop segment fixtures, 2 runs each; total server time per mux job:
The muxed MP4, thumbnail and GIF are byte-identical to today's build in every configuration.
Rejected along the way (not in this PR):
Tests
Content-Rangeis rejected;

Confidence Score: 5/5
The PR appears safe to merge; no new blocking issues were found.Summary
This PR speeds up recording verification while keeping parallel decoding and downloads behind opt-in settings.
Reviews (2) · Last reviewed commit: "fix(media-server): stop chunk copies on ..." · Reviewed by Greptile