Repository navigation
fix(desktop-gpui): ignore stale profile responses after sign-in - #3057
Merged
Merged
Conversation
Contributor
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the settings window refreshes your profile and avatar in the background, and if one of those requests comes back with a 401 it signs you out. it only checked that the user id was still the same, so if you signed out and back in as the same account, or switched servers, while a request was in flight, the old 401 landed after and cleared the new session.
the callbacks now compare the token and server as well as the user, so a response only applies to the session that started it. test covers the same user signing in again and a server change.
The PR appears safe to merge.Summary
The settings window now checks the user, token, and server before applying profile or avatar responses.
Reviews (1) · Last reviewed commit: "fix(desktop-gpui): ignore stale profile ..." · Reviewed by Greptile