Repository navigation
fix(desktop-gpui): decode transcription audio in comma-decimal locales - #3058
Merged
Merged
Conversation
Contributor
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2370 made the export and editor resamplers locale safe, but the decoder that prepares audio for local transcription still passed the cutoff as 0.97. under a comma-decimal locale like de_DE, ffmpeg rejects that with invalid argument, so generating captions fails on those linux setups.
it now uses the same shared resampler options as everything else, which write the cutoff as 97/100. that helper already has its own comma-decimal locale test in cap-audio, so this is just moving the last call site onto it. checked the transcription verify case still passes.


Confidence Score: 5/5
This PR appears safe to merge.Summary
Updates transcription audio decoding to use
high_quality_resampler_options().Reviews (1) · Last reviewed commit: "fix(desktop-gpui): decode transcription ..." · Reviewed by Greptile