Skip to content

fix(desktop-gpui): decode transcription audio in comma-decimal locales - #3058

Merged
richiemcilroy merged 1 commit into
CapSoftware:mainfrom
yashranaway:fix/locale-resampler
Oct 24, 2026
Merged

richiemcilroy merged 1 commit into
CapSoftware:mainfrom
yashranaway:fix/locale-resampler

Conversation

@yashranaway

@yashranaway yashranaway commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

#2370 made the export and editor resamplers locale safe, but the decoder that prepares audio for local transcription still passed the cutoff as 0.97. under a comma-decimal locale like de_DE, ffmpeg rejects that with invalid argument, so generating captions fails on those linux setups.

it now uses the same shared resampler options as everything else, which write the cutoff as 97/100. that helper already has its own comma-decimal locale test in cap-audio, so this is just moving the last call site onto it. checked the transcription verify case still passes.

RetriggerView in GreptileConfidence Score: 5/5

This PR appears safe to merge.

Summary

Updates transcription audio decoding to use high_quality_resampler_options().

  • Transcription audio decodes with locale-safe resampler settings.

Reviews (1) · Last reviewed commit: "fix(desktop-gpui): decode transcription ..." · Reviewed by Greptile

@vercel

vercel Bot commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

@richiemcilroy
richiemcilroy merged commit 275a9a9 into CapSoftware:main Oct 24, 2026
39 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants