[yashranaway]

share uploads go part by part and retry failed parts at the end, but progress moved forward for every part it read, whether or not that part actually uploaded. so with a flaky connection the bar could sit at 99% with parts still missing, and a failed share would hit 99% right before erroring out.

progress now only moves when a part is accepted, including when a retry succeeds, so on a normal upload it looks exactly the same as before. test makes one part fail twice and checks progress stops at what really got uploaded.

Confidence Score: 5/5

The PR appears safe to merge; no blocking issues remain.

Summary

Share progress now counts only successfully uploaded bytes, including successful retries.

• Share progress advances only when an upload part succeeds.

_{Reviews (2) · Last reviewed commit: "test(desktop-gpui): assert progress valu..." · Reviewed by Greptile}

[vercel]

@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

[richiemcilroy]

Thanks, the progress change looks right. One test gap:

1. failed_part_is_retried_after_the_rest_and_upload_completes now only records the started-part counts and drops the old final-value check, so it would still pass if the retry branch stopped adding to uploaded_bytes. Please assert the progress values too, including 0.9 and 0.99 after the two successful retries.

Once that's in, we'll re-run the Greptile review. It needs a 5/5 plus green CI to merge.

[yashranaway]

@greptileai review

[yashranaway]

@richiemcilroy done in 4ba677c. the retry test now asserts every progress value along with the started part count, ending in 0.9 and 0.99 for the two retries. i checked it fails if the retry branch stops adding to uploaded_bytes. greptile is 5/5.