Repository navigation
fix(recording): apply the resolution limit to X11 display and area capture - #3065
Merged
Merged
Conversation
Contributor
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
Thanks, the capture change looks right. One test issue:
Once that's in, we'll re-run the Greptile review. It needs a 5/5 plus green CI to merge. |
Contributor
Author
|
@greptileai review |
Contributor
Author
|
@richiemcilroy done in 56b1aa5. the tests now share an async mutex that each one holds from paint_display() until its last capture, so they can't repaint each other. i ran all three in parallel on an 800x600 xvfb display and they pass. greptile is 5/5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on x11, display and area recordings ignored the max resolution setting and always recorded at the native size, so a 4k screen with a 1080p cap still produced a 4k file. wayland and the other platforms already scale down to the limit.
the x11 source now grabs the full display or area as before and hands the grabber the constrained output size, so the existing frame scaler downsizes it, same as the pipewire path. window capture is untouched since it follows the window's own geometry. tests run against a dedicated 800x600 xvfb display and cover display, area and the encoded file, ignored by default like the other x11 capture tests.


Confidence Score: 5/5
The PR appears safe to merge.Summary
X11 display and area capture now keep the full capture region while scaling frames to the selected resolution limit. Window capture keeps its existing sizing.
Reviews (2) · Last reviewed commit: "test(recording): hold the shared display..." · Reviewed by Greptile