Repository navigation
fix(rendering): scale text wrap allowance with output resolution - #3066
Merged
Merged
Conversation
Contributor
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
text boxes get a bit of extra width when shaping so a line that fit in the editor doesn't wrap in the render. part of that slack was a fixed 4 pixels, while the font size and the box itself scale with output height. so at 4k the slack was half as big relative to the text, and a line sitting right at the edge could wrap in a 4k export even though it fit in the editor and at 1080p.
the fixed part now scales against the same 1080p reference the text sizes already use, so 1080p is unchanged and other resolutions keep the same proportion. test renders the same box at 1080p and 2160p and checks the wrap width scales with it.


Confidence Score: 5/5
The PR appears safe to merge.Summary
Makes the extra text wrapping width scale with output height, using the same 1080p reference as text sizes.
Reviews (1) · Last reviewed commit: "fix(rendering): scale text wrap allowanc..." · Reviewed by Greptile