Skip to content

fix(rendering): scale text wrap allowance with output resolution - #3066

Merged
richiemcilroy merged 1 commit into
CapSoftware:mainfrom
yashranaway:fix/rendering-skia
Oct 24, 2026
Merged

richiemcilroy merged 1 commit into
CapSoftware:mainfrom
yashranaway:fix/rendering-skia

Conversation

@yashranaway

@yashranaway yashranaway commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

text boxes get a bit of extra width when shaping so a line that fit in the editor doesn't wrap in the render. part of that slack was a fixed 4 pixels, while the font size and the box itself scale with output height. so at 4k the slack was half as big relative to the text, and a line sitting right at the edge could wrap in a 4k export even though it fit in the editor and at 1080p.

the fixed part now scales against the same 1080p reference the text sizes already use, so 1080p is unchanged and other resolutions keep the same proportion. test renders the same box at 1080p and 2160p and checks the wrap width scales with it.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge.

Summary

Makes the extra text wrapping width scale with output height, using the same 1080p reference as text sizes.

  • Text boxes keep their wrap room proportional as exports grow.

Reviews (1) · Last reviewed commit: "fix(rendering): scale text wrap allowanc..." · Reviewed by Greptile

@vercel

vercel Bot commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

@richiemcilroy
richiemcilroy merged commit 40896de into CapSoftware:main Oct 24, 2026
46 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants