Repository navigation
fix: show hours in the Chrome extension's timers and mobile chapter times - #3312
Merged
richiemcilroy merged 2 commits intoOct 26, 2026
Merged
richiemcilroy merged 2 commits into
richiemcilroy merged 2 commits into
Conversation
The recording timer on the page and in the popup, and recording durations on the options page, counted minutes past 59, so a recording 1 h 5 m 5 s long read 65:05. Print H:MM:SS from an hour on; shorter times print as before.
A cap's chapter list counted minutes past 59, so a chapter 1 h 5 m in read 65:05. Move formatChapterTime into utils/format with hours from an hour on, and make the label's 44 pt width a minimum, since from two hours on some labels measure up to 46.3 pt.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
richiemcilroy
approved these changes
Oct 26, 2026
richiemcilroy
left a comment
richiemcilroy
left a comment
Member
There was a problem hiding this comment.
Thanks, checked the output under and over an hour and the tests pin it.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3303.
The Chrome extension and the mobile app formatted times as minutes and seconds only, so anything past the hour mark read as a minute count,
65:05instead of1:05:05:shared/format-duration.ts)app/caps/[id].tsx)Both now print
H:MM:SSfrom an hour on, and under an hour they print exactly what they did before. The extension keeps truncating live timers and rounding finished recordings.On mobile,
formatChapterTimemoves intosrc/utils/format.tsso it can be tested, and the chapter time's fixed 44 pt width becomes a minimum width. Measured with the app's Neue Montreal Medium at 13 pt, every1:MM:SSlabel fits in 44 pt (43.3 pt at most), but from two hours on some reach 46.3 pt (6:00:00). Labels that fit keep the same 44 pt column.Tests
src/shared/format-duration.test.ts, which fails without the change (60:00instead of1:00:00).bun run --cwd apps/chrome-extension test: 39 passed.typecheckclean.src/utils/format.test.ts, which fails without the change.bun run --cwd apps/mobile test: 289 passed.typecheckclean.
The PR appears safe to merge.Summary
The PR adds
H:MM:SSlabels for Chrome extension timers, saved recording durations, and mobile chapter times.No actionable issues were found. Tests and visual checks were not run during this review.
Reviews (1) · Last reviewed commit: "fix(mobile): show hours in chapter times" · Reviewed by Greptile