Repository navigation
feat(desktop-gpui): macOS control styling across Cap's windows - #3484
Open
richiemcilroy wants to merge 15 commits into
Open
richiemcilroy wants to merge 15 commits into
richiemcilroy wants to merge 15 commits into
Conversation
…ups, buttons and the main window
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
… the Window tile picks by hover
richiemcilroy
marked this pull request as ready for review
October 27, 2026 21:32
Comment on lines
+40
to
+41
| /// The system pop-up's look: the value as plain text, then an up-down | ||
| /// chevron in a round chip of this fill. |
Contributor
There was a problem hiding this comment.
The new comment above chip describes the appearance already shown by the field and render code. AGENTS.md requires comments to explain non-obvious context and bans comments that merely narrate code. The new comment above thumb() repeats its return values in the same way. Remove these comments before merging to meet that requirement.
Context Used: AGENTS.md (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/desktop-gpui/src/ui/select.rs
Line: 40-41
Comment:
**Comments repeat the code**
The new comment above `chip` describes the appearance already shown by the field and render code. `AGENTS.md` requires comments to explain non-obvious context and bans comments that merely narrate code. The new comment above `thumb()` repeats its return values in the same way. Remove these comments before merging to meet that requirement.
**Context Used:** AGENTS.md ([source](https://github.com/capsoftware/cap/blob/main/AGENTS.md))
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This comment has been minimized.
This comment has been minimized.
Member
Author
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #3456. Restyles Cap's own windows to match how macOS 27 draws its controls, measured from macOS's own controls captured by
scripts/glass-reference/gallery.swift(key window, light and dark).Following Apple's rule that glass does not stack on glass, controls inside Cap's glass windows take the flat in-window style macOS uses there, not refractive panes.
So far:
Still to do: dropdown menus, the recordings library, the editor, segmented controls and text fields, then side-by-side comparisons against the Apple gallery on macOS and the cross-OS check.
Draft and held with the rest of the stack.


Confidence Score: 5/5
The reviewed changes appear safe to merge.Summary
Restyles settings controls and the main window to match macOS controls.
Reviewed the full PR because the previous and current heads have different merge bases with the target. Checks were static; the native UI was not run.
Reviews (2) · Last reviewed commit: "chore(desktop-gpui): drop comments that ..." · Reviewed by Greptile