[HlaKarki]

Fixes #3634

On macOS, gpui turns ⌘⇧4 into cmd-$ with Shift cleared, so the shortcut recorder rejected every ⌘⇧ combo on a digit or symbol key.

unfold_shifted_symbol maps the 21 US shifted symbols back to their key and restores Shift. It only does that while the recorder's held modifiers say Shift is down. Those come from window.modifiers() and on_modifiers_changed. AZERTY has an unshifted $ key, and without that check it would record as ⌘⇧4.

The mapping assumes a US layout, like the existing punctuation table in hotkey_code_for_key. Recording the physical key would need gpui's Keystroke to carry the key code, which is a bigger change in the fork.

Testing

• cargo test --bin cap-gpui on macOS 27.0: 1565 passed, 0 failed, 32 ignored.
• The new shifted_symbols_record_as_their_key_with_shift test covers all 21 symbols, the AZERTY $ case and letters.
• Dev build on macOS 27.0: ⌘⇧4 records as ⌘⇧4 and takes an area screenshot.

Confidence Score: 5/5

The PR appears safe to merge; no actionable issues were found.

Summary

Restores Shift and the US base key when GPUI reports a shifted symbol with Shift cleared.

• The shortcut recorder saves shifted symbols as their base keys with Shift.

HlaKarki explicitly treats US-layout mapping as intentional and defers physical-key support to a broader GPUI change.

_{Reviews (1) · Last reviewed commit: "fix: shortcut recorder; record Shift sho..." · Reviewed by Greptile}

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
cap-status	Skipped		Nov 2, 2026 12:17am UTC