Skip to content

Only upload test results to Codecov when pytest actually ran #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnRDOrazio merged 1 commit into from
Aug 3, 2026
Merged

Only upload test results to Codecov when pytest actually ran #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ jobs:
run: pyright

- name: pytest
id: pytest
run: pytest -q --cov --cov-branch --cov-report=term-missing --cov-report=xml --junitxml=junit.xml

- name: Coverage summary
Expand All @@ -46,8 +47,13 @@ jobs:
slug: CatholicOS/martyrology-api
files: coverage.xml

# Upload results when pytest RAN, pass or fail — a failing suite is
# exactly when Codecov's test analytics earns its keep. Skip when pytest
# never ran (an earlier step failed), since there is no junit.xml to find
# and the resulting "unable to find any JUnit XML files" notice reads like
# a config fault while distracting from the real failure.
- name: Upload test results to Codecov
if: ${{ !cancelled() }}
if: ${{ !cancelled() && steps.pytest.conclusion != 'skipped' }}
uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f # v7.0.0
with:
token: ${{ secrets.CODECOV_TOKEN }}
Expand Down