-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paintroid-450 : Add share menu option in paint view #49
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The share package seems to be deprecated see here. Please always check if packages are maintained before adding them.
Also- add tests please :)
@Lenkomotive I have changed the package to share_plus. and have added the tests also. while Native share windows cannot be tested in Flutter widget tests because these tests run in a Dart VM, that does not interact with native components. I have implemented a workaround of checking the entire widget tree before and after, looking for any unexpected behaviour and error dialog. If anything else needs to be changed let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls check my comments. thanks
packages/features/workspace_screen/test/widget/workspace_screen_test.dart
Outdated
Show resolved
Hide resolved
packages/features/workspace_screen/lib/src/components/top_bar/overflow_menu.dart
Outdated
Show resolved
Hide resolved
Thank you for the PR! |
@juliajulie95 I intended to do the same initially only but was waiting for additional info like the default format of shared images, whether manual image compression is required or not etc 🙂 , I tried to get more info on the Jira ticket only. So I ended up placing a text-only |
Sorry for that. |
Are we still working on this ticket? @juliajulie95 @msesko |
Ticket
https://catrobat.atlassian.net/browse/PAINTROID-450
Paintroid-450 : Add share menu option in paint view
Description
Add "share" option to the paint view overflow menu.
This should open the phone native share window.
New Features and Enhancements
Refactorings and Bug Fixes
Checklist
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.