Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paintroid 611 - Add main options to landing page #1291

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

Rd4dev
Copy link
Contributor

@Rd4dev Rd4dev commented Jun 19, 2023

PAINTROID-611: Add main options to landing page

Relocated main options from the MainActivity to LandingPageActivity

Main Options:

  • Rate Us!
  • Help
  • About
  • Feedback

For testability purposes the application ID is set to "org.catrobat.paintroid"

checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #paintroid Slack channel and ask for a code reviewer

@khalid-nasralla
Copy link
Contributor

Looks good to me.

Copy link
Contributor

@foenabua foenabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aman021202
Copy link

Kindly assign me this issue .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants